-
Notifications
You must be signed in to change notification settings - Fork 1k
Add JS validation when passwords do not match #3197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sure, I'll take the opportunity to rewrite the feature in Stimulus. Disabling the submit button was something we explored before and decided against it. We are now using a pattern where feedback is given when clicking on the submit button in the form of tooltips. Do we want to mix both feedback flows? |
@yeraydiazdiaz Great question. The submit button disabling was a problem on the registration form because there wasn't a way to provide feedback if the user was missing one of the required fields. I think here it's OK, since it should be pretty clear to the user that they need to fill out the password field in order to be able to change their password, and we'll be able to conditionally show the "passwords match"/"don't match" message when the first field is filled out. |
@nlhkabu which CSS classes are you using for the messages? The closest thing I'm finding are badges and don't quite look the same |
@yeraydiazdiaz you could use |
* Disable form and show warning on mismatch when updating password (#3197) * Add password match feature to register and reset password forms
It would be nice to use JavaScript to indicate whether or not the passwords match:
@yeraydiazdiaz would this be something you might enjoy working on?
The text was updated successfully, but these errors were encountered: