Change recovery codes filename to reflect testpypi or pypi

[diegoe]

What's the problem this feature will solve?
Currently if you generate recovery codes for testpypi and pypi, both files are suggested for download as PyPI-Recovery-Codes.txt.

Describe the solution you'd like
The suggested filename reflects the origin. Example: TestPyPi-Recovery-Codes.txt and PyPi-Recovery-Codes.txt.

Additional context
It should be possible to change it to an if/else to set a prefix at:
https://github.com/pypa/warehouse/blob/main/warehouse/templates/manage/account/recovery_codes-provision.html#L64-L66

[ewdurbin]

@diegoe this is an excellent suggestion. If you'd like to open a Pull Request with this change the necessary logic for determining when to prefix is visible in https://github.com/pypa/warehouse/blob/60afeb136c55574b0deb6c36a2a416c951203633/warehouse/templates/base.html#L74-L76

[ewdurbin]

I'm not positive, but the testPyPI variable may even be accessible since the template for the recovery codes extends from manage_base which extends from base.

[di]

I'm not positive, but the testPyPI variable may even be accessible since the template for the recovery codes extends from manage_base which extends from base.

Yes, this should be true!

I've added the "good first issue" label to this issue.

[abidahmadq]

@di I can try this issue if you can give me more context.

[AustinTSchaffer]

@Abid1998 I'm not di, but commenting for additional context:

If you set up an account, verify your email address, and set up 2-factor authentication, the "Account Settings" menu gives you an additional option for generating/regenerating account recovery codes. These codes can be used to get access to your account in the event your 2-factor authentication device becomes inaccessible, gets lost, breaks, etc. Once you generate some codes, you have the option to download them as a text file.

(I generated these codes running warehouse on localhost, but figured I should partially black them out anyway.)

This would be changing the default name for that text file to "TestPyPI-Recovery-Codes.txt" when you're on test.pypi.org, as opposed to "PyPI-Recovery-Codes.txt" when you're on pypi.org, probably to reduce confusion and prevent users from overwriting their actual recovery codes when using test.pypi.org.

Hope this helps!

[deniszh]

Hello!
I created PR #9535 for fixing this. Let me know if I doing something terribly wrong.
/cc @ewdurbin @di

Thanks a lot!

[ewjoachim]

I think it's all good now, thanks.