[OIDC] Pending provider views, routes, forms

tests/unit/manage/test_views.py

@@ -9959,10 +9959,9 @@ def test_add_github_oidc_provider_oidc_not_enabled(self):
 
     def test_add_github_oidc_provider_admin_disabled(self, monkeypatch):
         project = pretend.stub()
-        metrics = pretend.stub(increment=pretend.call_recorder(lambda *a, **kw: None))
         request = pretend.stub(
             registry=pretend.stub(settings={"warehouse.oidc.enabled": True}),
-            find_service=lambda *a, **kw: metrics,
+            find_service=lambda *a, **kw: None,
             flags=pretend.stub(enabled=pretend.call_recorder(lambda f: True)),
             session=pretend.stub(flash=pretend.call_recorder(lambda *a, **kw: None)),
             _=lambda s: s,
@@ -9975,11 +9974,6 @@ def test_add_github_oidc_provider_admin_disabled(self, monkeypatch):
         )
 
         assert view.add_github_oidc_provider() == default_response
-        assert view.metrics.increment.calls == [
-            pretend.call(
-                "warehouse.oidc.add_provider.attempt", tags=["provider:GitHub"]
-            ),
-        ]
         assert request.session.flash.calls == [
             pretend.call(
                 (
@@ -10336,10 +10330,9 @@ def test_delete_oidc_provider_oidc_not_enabled(self):
 
     def test_delete_oidc_provider_admin_disabled(self, monkeypatch):
         project = pretend.stub()
-        metrics = pretend.stub(increment=pretend.call_recorder(lambda *a, **kw: None))
         request = pretend.stub(
             registry=pretend.stub(settings={"warehouse.oidc.enabled": True}),
-            find_service=lambda *a, **kw: metrics,
+            find_service=lambda *a, **kw: None,
             flags=pretend.stub(enabled=pretend.call_recorder(lambda f: True)),
             session=pretend.stub(flash=pretend.call_recorder(lambda *a, **kw: None)),
         )
@@ -10351,11 +10344,6 @@ def test_delete_oidc_provider_admin_disabled(self, monkeypatch):
         )
 
         assert view.delete_oidc_provider() == default_response
-        assert view.metrics.increment.calls == [
-            pretend.call(
-                "warehouse.oidc.delete_provider.attempt",
-            ),
-        ]
         assert request.session.flash.calls == [
             pretend.call(
                 (

tests/unit/oidc/test_forms.py

@@ -14,12 +14,51 @@
 import pytest
 import wtforms
 
-from requests import HTTPError, Timeout
+from requests import ConnectionError, HTTPError, Timeout
 from webob.multidict import MultiDict
 
 from warehouse.oidc import forms
 
 
+class TestPendingGitHubProviderForm:
+    def test_creation(self):
+        project_factory = pretend.stub()
+        form = forms.PendingGitHubProviderForm(
+            api_token="fake-token", project_factory=project_factory
+        )
+
+        assert form._project_factory == project_factory
+
+    def test_validate_project_name_already_in_use(self):
+        project_factory = ["some-project"]
+        form = forms.PendingGitHubProviderForm(
+            api_token="fake-token", project_factory=project_factory
+        )
+
+        field = pretend.stub(data="some-project")
+        with pytest.raises(wtforms.validators.ValidationError):
+            form.validate_project_name(field)
+
+    def test_validate(self, monkeypatch):
+        data = MultiDict(
+            {
+                "owner": "some-owner",
+                "repository": "some-repo",
+                "workflow_filename": "some-workflow.yml",
+                "project_name": "some-project",
+            }
+        )
+        form = forms.PendingGitHubProviderForm(
+            MultiDict(data), api_token=pretend.stub(), project_factory=[]
+        )
+
+        # We're testing only the basic validation here.
+        owner_info = {"login": "fake-username", "id": "1234"}
+        monkeypatch.setattr(form, "_lookup_owner", lambda o: owner_info)
+
+        assert form.validate()
+
+
 class TestGitHubProviderForm:
     @pytest.mark.parametrize(
         "token, headers",
@@ -138,6 +177,7 @@ def test_lookup_owner_http_timeout(self, monkeypatch):
             get=pretend.raiser(Timeout),
             Timeout=Timeout,
             HTTPError=HTTPError,
+            ConnectionError=ConnectionError,
         )
         monkeypatch.setattr(forms, "requests", requests)
 
@@ -152,6 +192,28 @@ def test_lookup_owner_http_timeout(self, monkeypatch):
             pretend.call("Timeout from GitHub user lookup API (possibly offline)")
         ]
 
+    def test_lookup_owner_connection_error(self, monkeypatch):
+        requests = pretend.stub(
+            get=pretend.raiser(ConnectionError),
+            Timeout=Timeout,
+            HTTPError=HTTPError,
+            ConnectionError=ConnectionError,
+        )
+        monkeypatch.setattr(forms, "requests", requests)
+
+        sentry_sdk = pretend.stub(capture_message=pretend.call_recorder(lambda s: None))
+        monkeypatch.setattr(forms, "sentry_sdk", sentry_sdk)
+
+        form = forms.GitHubProviderForm(api_token="fake-token")
+        with pytest.raises(wtforms.validators.ValidationError):
+            form._lookup_owner("some-owner")
+
+        assert sentry_sdk.capture_message.calls == [
+            pretend.call(
+                "Connection error from GitHub user lookup API (possibly offline)"
+            )
+        ]
+
     def test_lookup_owner_succeeds(self, monkeypatch):
         fake_owner_info = pretend.stub()
         response = pretend.stub(

tests/unit/test_routes.py

@@ -197,6 +197,9 @@ def add_policy(name, filename):
             domain=warehouse,
         ),
         pretend.call("manage.account", "/manage/account/", domain=warehouse),
+        pretend.call(
+            "manage.account.publishing", "/manage/account/publishing/", domain=warehouse
+        ),
         pretend.call(
             "manage.account.two-factor",
             "/manage/account/two-factor/",