Activate coverage earlier when not in xdist #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, it fails with xdist: (see Travis output). |
| """Activate coverage plugin if appropriate.""" | ||
| exists = getattr(early_config, "known_args_namespace", None) is not None | ||
| if not exists: # pragma: no cover | ||
| # this if is a hacky thing for versions of pytest that do not include |
There was a problem hiding this comment.
Yes, we should just wait for pytest 2.6 release and then depend on it.
|
I have a working solution for central and xdist tests. So I'm closing this in favor of #4. But there is still some work to do if you want to jump in. |
cclauss
added a commit
to cclauss/pytest-cov
that referenced
this pull request
Feb 19, 2023
# This is the 1st commit message: Add Python 3.11 and PyPy 3.9 to the testing # The commit message pytest-dev#2 will be skipped: # tox.ini: Add py311 and pypy39 # The commit message pytest-dev#3 will be skipped: # pytest72 # The commit message pytest-dev#4 will be skipped: # xdist302 # # Co-authored-by: Mason Lin <[email protected]> # The commit message pytest-dev#5 will be skipped: # coverage65 # # Co-authored-by: Mason Lin <[email protected]> # The commit message pytest-dev#6 will be skipped: # Drop py36 and upgrade to pytest-xdist==3.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to pass the tests, as they are; I did not test under xdist, however, so it could be horribly broken (though I doubt it's more broken than a typo's worth). This does work for my application, which is a single-process run.