Ordering of tests #223
Merged
Ordering of tests #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Squashed/rebased. |
blueyed
force-pushed
the
order-of-tests
branch
from
48ac3b7 to
9f5645e
Compare
|
Should/could get improved based on #214 (comment). |
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
========================================
- Coverage 98.03% 98% -0.04%
========================================
Files 32 32
Lines 1831 1853 +22
Branches 142 147 +5
========================================
+ Hits 1795 1816 +21
- Misses 23 24 +1
Partials 13 13
Continue to review full report at Codecov.
|
blueyed
force-pushed
the
order-of-tests
branch
from
78c73c4 to
20bf80b
Compare
blueyed
force-pushed
the
order-of-tests
branch
from
20bf80b to
d7d89c7
Compare
This uses `pytest_collection_modifyitems` to order the tests. Fixes pytest-dev#214.
blueyed
commented
Mar 14, 2019
callahad
added a commit
to callahad/pytest-django
that referenced
this pull request
Feb 27, 2020
Pytest-django 3.5.0 attempts to run tests in the same order as Django: Issue pytest-dev#223, Commit 5a79fba Pytest itself can re-order tests to prioritize previously failed tests (--failed-first), incremental runs of the test suite (--stepwise), etc. However, pytest-django's re-ordering clobbers pytest's, which can break those options as reported in pytest-dev#819. By applying the @pytest.hookimpl(tryfirst=True) decorator to pytest_collection_modifyitems(), pytest-django's re-ordering happens first, and nolonger clobbers the later re-ordering performed by pytest. Fixes pytest-dev#819
callahad
added a commit
to callahad/pytest-django
that referenced
this pull request
Feb 27, 2020
Pytest-django 3.5.0 attempts to run tests in the same order as Django: Issue pytest-dev#223, Commit 5a79fba Pytest itself can re-order tests to prioritize previously failed tests (--failed-first), incremental runs of the test suite (--stepwise), etc. However, pytest-django's re-ordering clobbers pytest's, which can break those options as reported in pytest-dev#819. By applying the @pytest.hookimpl(tryfirst=True) decorator to pytest_collection_modifyitems(), pytest-django's re-ordering happens first, and does not clobber the later re-ordering performed by pytest. Fixes pytest-dev#819
blueyed
pushed a commit
that referenced
this pull request
Feb 28, 2020
Pytest-django 3.5.0 attempts to run tests in the same order as Django: Issue #223, Commit 5a79fba Pytest itself can re-order tests to prioritize previously failed tests (--failed-first), incremental runs of the test suite (--stepwise), etc. However, pytest-django's re-ordering clobbers pytest's, which can break those options as reported in #819. By applying the @pytest.hookimpl(tryfirst=True) decorator to pytest_collection_modifyitems(), pytest-django's re-ordering happens first, and does not clobber the later re-ordering performed by pytest. Fixes #819
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #214.
TODO: