Don't break --failed-first when re-ordering tests #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytest-django 3.5.0 attempts to run tests in the same order as Django: Issue pytest-dev#223, Commit 5a79fba Pytest itself can re-order tests to prioritize previously failed tests (--failed-first), incremental runs of the test suite (--stepwise), etc. However, pytest-django's re-ordering clobbers pytest's, which can break those options as reported in pytest-dev#819. By applying the @pytest.hookimpl(tryfirst=True) decorator to pytest_collection_modifyitems(), pytest-django's re-ordering happens first, and does not clobber the later re-ordering performed by pytest. Fixes pytest-dev#819
|
Thanks! A fix for pytest also makes sense additionally: blueyed/pytest#262 |
This was referenced Sep 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pytest-django 3.5.0 attempts to run tests in the same order as Django:
Issue #223, Commit 5a79fba
Pytest itself can re-order tests to prioritize previously failed tests
(
--failed-first), incremental runs of the test suite (--stepwise), etc.However, pytest-django's re-ordering clobbers pytest's, which can break
those options as reported in #819.
By applying the
@pytest.hookimpl(tryfirst=True)decorator topytest_collection_modifyitems(), pytest-django's re-ordering happensfirst, and does not clobber the later re-ordering performed by pytest.
Fixes #819