Handle flaky windows test by rerunning #414
Conversation
BeyondEvil
force-pushed
the
rerun-flaky-test
branch
from
84bba34 to
0b58238
Compare
testing/test_pytest_html.py
Outdated
| "with_ansi", | ||
| [True, False], |
There was a problem hiding this comment.
This was introduced by the new version of Black.
Pipfile
Outdated
| flake8 = "==3.8.4" | ||
| black = "==20.8b1" |
There was a problem hiding this comment.
Pin versions in Pipfile to same as the ones in .pre-commit-config.yml to avoid inconsistencies.
.pre-commit-config.yaml
Outdated
| - repo: https://github.com/psf/black | ||
| rev: 19.10b0 | ||
| - repo: https://github.com/psf/black | ||
| rev: 20.8b1 |
There was a problem hiding this comment.
new version of Black
.pre-commit-config.yaml
Outdated
| - repo: https://gitlab.com/pycqa/flake8 | ||
| rev: 3.8.2 | ||
| - repo: https://gitlab.com/pycqa/flake8 | ||
| rev: 3.8.4 |
There was a problem hiding this comment.
new version of Flake8
|
Can we split the changes due to the version upgrades of flake8 and black into a different PR since it's not related to the flaky test? It would be a cleaner commit history. |
|
Sure @gnikonorov! I can sort it tomorrow. 👍 |
|
Thank you, @BeyondEvil ! |
BeyondEvil
force-pushed
the
rerun-flaky-test
branch
from
0b58238 to
7939e5f
Compare
|
Fixed @gnikonorov , will update/rebase this once #416 is merged. |
gnikonorov
added
skip-changelog
BeyondEvil
force-pushed
the
rerun-flaky-test
branch
from
7939e5f to
481c4cd
Compare
|
Let's get this reviewed and merged @gnikonorov 🙏 |
|
Can you update the description of this PR too ( or just removed the blocked part ) |
I'm thinking about opening a PR with pytest-rerunfailures so that we can provide a condition for the rerun. I only want it to rerun on windows machines.
The styling/indentation changes to .pre-commit-config.yml was made by my yaml linter.
I'm reluctant to set #395 to "fixed" by this PR.