Add optional condition to marker #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeyondEvil
force-pushed
the
add-optional-condition
branch
3 times, most recently
from
86727d5 to
14e133c
Compare
BeyondEvil
commented
Dec 13, 2020
sallner
requested changes
Dec 14, 2020
There was a problem hiding this comment.
Thank you for your contribution. I think, that the addition of this kind of condition is still within the scope of this package, although it overlaps somehow with the possibility to only rerun certain errors.
The only thing I really want to know is the intention of the warning, otherwise I like the PR.
BeyondEvil
force-pushed
the
add-optional-condition
branch
2 times, most recently
from
91deb02 to
372a664
Compare
BeyondEvil
force-pushed
the
add-optional-condition
branch
from
372a664 to
4a120d5
Compare
BeyondEvil
commented
Dec 14, 2020
BeyondEvil
commented
Dec 14, 2020
sallner
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use case we have in pytest-html is that we have a test that is flaky only on Windows, so I'd like that test to re-run on the condition that it is running in a Windows environment.
@gnikonorov