Skip to content

Conversation

gnikonorov
Copy link
Member

Split plugin.py into files based on class ( plus a utility file ) to make it easier to read/develop. The original file was way too large and did too much ( IMO ). I've introduced 0 functionality changes, this pr is only breaking plugin.py into smaller files

@gnikonorov gnikonorov added skip-changelog Can be missed from the changelog. code quality This PR has to do with improving code readability/quality ( refactoring, etc. ) labels Dec 17, 2020
@gnikonorov gnikonorov self-assigned this Dec 17, 2020
Copy link
Contributor

@BeyondEvil BeyondEvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gnikonorov

This comment has been minimized.

@gnikonorov
Copy link
Member Author

CI failures are resolved ( see #429 for details on what went wrong ).

Merging as change is approved

@gnikonorov gnikonorov merged commit c9f442b into pytest-dev:master Dec 18, 2020
BeyondEvil pushed a commit to BeyondEvil/pytest-html that referenced this pull request May 10, 2021
BeyondEvil added a commit that referenced this pull request Jan 26, 2022
* remove phantomjs dependency (#424)

* properly classify all npm dependencies (#425)

* Move the changelog to read the docs (#423)

* split plugin.py into smaller files (#427)

* Implement the visible URL query parameter to control visibility of test results on page load. (#433)

* enable control of test result visability via query params

* Allow for redacting of environment table values (#431)

* Disable Codecov (#480)

* Disable Codecov

* Disable pypy3 on mac

* Add Tests.yml reusable workflow (#484)

* Use the tests reusable workflow (#486)

* Migrate to precommit.ci (#487)

* Separate Nightly workflow (#488)

Co-authored-by: Gleb Nikonorov <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
BeyondEvil pushed a commit to BeyondEvil/pytest-html that referenced this pull request Apr 3, 2023
BeyondEvil added a commit to BeyondEvil/pytest-html that referenced this pull request Apr 3, 2023
* remove phantomjs dependency (pytest-dev#424)

* properly classify all npm dependencies (pytest-dev#425)

* Move the changelog to read the docs (pytest-dev#423)

* split plugin.py into smaller files (pytest-dev#427)

* Implement the visible URL query parameter to control visibility of test results on page load. (pytest-dev#433)

* enable control of test result visability via query params

* Allow for redacting of environment table values (pytest-dev#431)

* Disable Codecov (pytest-dev#480)

* Disable Codecov

* Disable pypy3 on mac

* Add Tests.yml reusable workflow (pytest-dev#484)

* Use the tests reusable workflow (pytest-dev#486)

* Migrate to precommit.ci (pytest-dev#487)

* Separate Nightly workflow (pytest-dev#488)

Co-authored-by: Gleb Nikonorov <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality This PR has to do with improving code readability/quality ( refactoring, etc. ) skip-changelog Can be missed from the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants