Allow for redacting of environment table values #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump for a review @BeyondEvil / @ssbarnea |
|
Bump for a review, @BeyondEvil |
|
Hey @gnikonorov ! Sorry for the delay! First the holidays and now I'm moving houses so my activity here is not going to be super high unfortunately. |
|
Thanks for the review @BeyondEvil! No worries at all! Happy new year and hope the move goes smoothly. |
BeyondEvil
pushed a commit
to BeyondEvil/pytest-html
that referenced
this pull request
May 10, 2021
* Add untested change * Add tests * Add documentation * Add the changelog entry * remove debug code from test * Change wording of documentation
BeyondEvil
added a commit
that referenced
this pull request
Jan 26, 2022
* remove phantomjs dependency (#424) * properly classify all npm dependencies (#425) * Move the changelog to read the docs (#423) * split plugin.py into smaller files (#427) * Implement the visible URL query parameter to control visibility of test results on page load. (#433) * enable control of test result visability via query params * Allow for redacting of environment table values (#431) * Disable Codecov (#480) * Disable Codecov * Disable pypy3 on mac * Add Tests.yml reusable workflow (#484) * Use the tests reusable workflow (#486) * Migrate to precommit.ci (#487) * Separate Nightly workflow (#488) Co-authored-by: Gleb Nikonorov <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
BeyondEvil
pushed a commit
to BeyondEvil/pytest-html
that referenced
this pull request
Apr 3, 2023
* Add untested change * Add tests * Add documentation * Add the changelog entry * remove debug code from test * Change wording of documentation
BeyondEvil
added a commit
to BeyondEvil/pytest-html
that referenced
this pull request
Apr 3, 2023
* remove phantomjs dependency (pytest-dev#424) * properly classify all npm dependencies (pytest-dev#425) * Move the changelog to read the docs (pytest-dev#423) * split plugin.py into smaller files (pytest-dev#427) * Implement the visible URL query parameter to control visibility of test results on page load. (pytest-dev#433) * enable control of test result visability via query params * Allow for redacting of environment table values (pytest-dev#431) * Disable Codecov (pytest-dev#480) * Disable Codecov * Disable pypy3 on mac * Add Tests.yml reusable workflow (pytest-dev#484) * Use the tests reusable workflow (pytest-dev#486) * Migrate to precommit.ci (pytest-dev#487) * Separate Nightly workflow (pytest-dev#488) Co-authored-by: Gleb Nikonorov <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the redaction of environment table values based on the newly added
environment_table_redact_listINI key.Please see the following for an example of a redacted environment table entry (
MY_SECRET_KEY):Closes #233