Skip to content

Extract the twisted greenlet initialization to a separate function #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2018

Conversation

vtitor
Copy link
Member

@vtitor vtitor commented Dec 25, 2017

Add an ability to use the plugin functionality in pytest hooks.

Example of usage:

import pytest

pytest_plugins = "pytest_twisted"

def pytest_configure(config):
    pytest.init_twisted_greenlet()
    ...

The similar stuff was requested in this issue #8. Additionally, I added config for running tests at travis-ci.

@schmir, @christianmlong Could you help me with this pr, please?

@schmir
Copy link
Contributor

schmir commented Dec 27, 2017

Hi vtitor, thanks for the PR.

I'm sorry, I don't maintain pytest-twisted anymore and it looks like @christianmlong is also inactive.

Do you want to take over maintainership? (I don't have the appropriate privileges to make you a maintainer, but I guess we can get someone from pytest-dev to do that).

@vtitor
Copy link
Member Author

vtitor commented Dec 27, 2017

Hi @schmir, thanks for the response. I will be glad to become the maintainer of this repository.
@pytest-dev Could you help with this, please?

@vtitor
Copy link
Member Author

vtitor commented Jan 8, 2018

@christianmlong, @hackebrot, @nicoddemus I'm sorry to bother you, but I need your help. Could you please grant me access?

@nicoddemus
Copy link
Member

nicoddemus commented Jan 8, 2018

Hi @vtitor, thanks for taking interest in taking over the maintenance of this plugin, I'm just hearing about this thread now (I think in order to ping pytest-dev you need to ping @pytest-dev/core, not @pytest-dev).

I've sent @christianmlong an email asking him if he is not maintaining the plugin anymore and if we can add @vtitor as new admin of this repository. We will have to wait at least a month to move this forward though, as stated by our policy:

Repository owners can rest assured that no pytest-dev administrator will ever make releases of your repository or take ownership in any way, except in rare cases where someone becomes unresponsive after months of contact attempts. As stated, the objective is to share maintenance and avoid "plugin-abandon".

In fact, I think we should open a separate issue to track this so it doesn't get mixed with this PR, so I opened #11. We can move discussion about this over there.

@vtitor vtitor merged commit e06e27c into pytest-dev:master Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants