Skip to content

[30] Test and claim Python 3.7 support #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2018

Conversation

altendky
Copy link
Member

#30

@altendky
Copy link
Member Author

[WIP] due to the use of Twisted from Git, if nothing else. They are one test/deprecation away from passing all tests on 3.7.

@altendky altendky changed the title [30] [WIP] Setup for Python 3.7 and Git Twisted [30] [WIP] Setup for Python 3.7 and Twisted w/ 3.7 support Sep 26, 2018
@JapieBosch
Copy link

Hi

So I'm very new to git and github, and I was just wondering what is going on here. From what I can tell, is that you worked on some files to make the module compatible with python 3.7. And are now waiting for someone to accept these changes to integrate it with the module and include it in the next release. Am I correct? If not will you please help me understand what is going on?

@altendky
Copy link
Member Author

Roughly yes. In the details I didn't have to change code per-se, I just enabled testing against 3.7 and add the 3.7 classifier for PyPI metadata. I could actually merge this myself but this is still a way to get a build of this to make sure it really works without committing it to the main branch.

For more info: https://help.github.com/articles/about-pull-requests/

@gardenunez
Copy link

Hi @altendky, is this issue blocked for any reason or do you think it will be merge and release soon? Need any help on it?

@altendky altendky changed the title [30] [WIP] Setup for Python 3.7 and Twisted w/ 3.7 support [30] Test and claim Python 3.7 support Oct 15, 2018
@altendky
Copy link
Member Author

@gardenunez thanks for the reminder. Twisted 18.9.0 with 3.7 support was just released. I think this is ready. @vtitor, care to review and merge?

I could technically merge this myself but I don't know the release process, but, @gardenunez do note that there was no actual code change here, just testing against Python 3.7 to make sure it worked and reporting support via the PyPI classifiers. This particular PR won't do anything directly for users.

@gardenunez
Copy link

Hi @altendky, you are totally right and I can install pytest-twisted for Python3.7 at the moment. Thanks.

@vtitor vtitor merged commit b78a6c9 into pytest-dev:master Oct 16, 2018
@vtitor vtitor mentioned this pull request Oct 16, 2018
@vtitor
Copy link
Member

vtitor commented Oct 16, 2018

Great work @altendky, thanks a lot. I will review your pull requests (#34, #37, ..) as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants