Skip to content

[31] Add @ensureDeferred for use with async/await #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jan 16, 2019
Merged

[31] Add @ensureDeferred for use with async/await #34

merged 19 commits into from
Jan 16, 2019

Conversation

altendky
Copy link
Member

#31

@altendky
Copy link
Member Author

@schmir and @vtitor, any opinions on this? Concerns?

@vtitor vtitor mentioned this pull request Oct 16, 2018
Merged
@altendky altendky mentioned this pull request Oct 26, 2018
Closed
meejah
meejah approved these changes Oct 26, 2018
View reviewed changes
Copy link

@meejah meejah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me. Couple minor things inline ...

@altendky altendky changed the title [31] Add async_callbacks() for use with async/await [31] Add ensureDeferred() for use with async/await Oct 26, 2018
@altendky
ensureDeferred -> async_await
aaff1ad 
A couple bike sheds later, another name thrash emerges
@altendky
Add async_yield as an alias for inlineCallbacks
b274d22 
For symmetry with the new async_await
@altendky altendky changed the title [31] Add ensureDeferred() for use with async/await [31] Add async_await() for use with async/await Oct 26, 2018
meejah
meejah approved these changes Oct 26, 2018
View reviewed changes
Copy link

@meejah meejah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@altendky altendky mentioned this pull request Oct 26, 2018
Closed
@altendky
Copy link
Member Author

@vtitor, obviously this isn't a huge rush but do you want to review this? Technically I've got permission to merge it myself and I've gotten a couple passes of review, but I prefer more review over less and don't want to go jumping ahead of any procedures or expectations.

Cheers,
-kyle

@vtitor
Copy link
Member

vtitor commented Nov 7, 2018

@altendky Unfortunately, I do not have enough time to maintain the repository. Do you want to take over maintainership?

@altendky altendky mentioned this pull request Nov 7, 2018
Closed
4 tasks
@altendky altendky changed the title [31] Add async_await() for use with async/await [31] Add @ensureDeferred for use with async/await Jan 16, 2019
@altendky altendky merged commit 681fa3d into pytest-dev:master Jan 16, 2019
@altendky altendky deleted the 31-altendky-async_callbacks branch January 16, 2019 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meejah meejah meejah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@altendky @vtitor @meejah