-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Run regen-docs for pytest 3.0 #1780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -246,8 +246,7 @@ the conftest file:: | |||
f1 = Foo(1) | |||
f2 = Foo(2) | |||
> assert f1 == f2 | |||
E assert Comparing Foo instances: | |||
E vals: 1 != 2 | |||
E AssertionError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this seems like a weird change seeing that the doc is about pytest_assertrepr_compare
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm yes, and I think that's a regression 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #1784 to investigate this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we still merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let @nicoddemus decide - I think we should probably fix #1784 before releasing 3.0, right? If so, we'd need to re-run regendoc anyways, so not much point in merging then from my POV.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next merge will be smaller :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks!
e4a758e
to
21a90c8
Compare
example/value contains: | ||
42 | ||
|
||
======= no tests ran in 0.12 seconds ======== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this meant to no longer run tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, at least that's what the cacheshow
function does.
No description provided.