invocation-scoped fixtures show up once with --fixtures #1782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for argname, fixturedefs in fm._arg2fixturedefs.items(): | ||
| assert fixturedefs is not None | ||
| if not fixturedefs: | ||
| continue | ||
| for fixturedef in fixturedefs: | ||
| loc = getlocation(fixturedef.func, curdir) | ||
| fixture_argname = fixturedef.argname | ||
| if ':' in fixture_argname: |
There was a problem hiding this comment.
When does fixture_argname have a :?
There was a problem hiding this comment.
When it's a invocation-scoped fixture. For example, defining monkeypatch as invocation-scoped will generate 4 fixture-defs in different scopes: "monkeypatch:function", "monkeypatch:class", "monkeypatch:module" and "monkeypatch:session".
There was a problem hiding this comment.
Ah, I see. Can you please add a comment? 😃
nicoddemus
force-pushed
the
invocation-fixtures-help
branch
from
13746b3 to
44ecf2a
Compare
|
Great! Happy to merge once you update the changelog 👍 |
|
I don't think it is necessary to update the changelog, after all invocation-scoped fixtures were not released yet. 😁 |
|
You have a point there! 😁 I just noticed that this is going to |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running regedocs for pytest 3.0 earlier today I noticed that invocation scoped fixtures appear more than once with
--fixtures.