feat(pyth-lazer) Create schema for lazer agent JRPC endpoint #2836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
ali-behjati
reviewed
Jul 7, 2025
lazer/sdk/rust/protocol/src/jrpc.rs
Outdated
| } | ||
|
|
||
| #[derive(Serialize, Deserialize)] | ||
| struct SymbolMetadata { |
There was a problem hiding this comment.
let's aim for a map <str -> str> for metadata. i think anything that is usable in the code should not live in metadata (like exponent) but that's a step in the future.
There was a problem hiding this comment.
I think BTreeMap<String, serde_value::Value> would be even better. We should support typed metadata instead of converting everything to string. I also agree about separating exponent, etc from arbitrary metadata.
There was a problem hiding this comment.
separating exponent, etc
Which fields do you consider to not be a part of the arbitrary metadata?
…eat/pyth-lazer/agent/jrpc-schema-1
bplatak
force-pushed
the
feat/pyth-lazer/agent/jrpc-schema-1
branch
from
da25fcd to
28e1346
Compare
3 tasks
keyvankhademi
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a new schema for the JRPC endpoint in
pyth-lazer-agentfor sending updates, and retrieving metadata via the JRPC endpoint. Also move theTimestamplogic toprotocolto reuse acrosspyth-lazerRationale
Adding a new endpoint for publishers to communicate with the
pyth-lazer-agent.How has this been tested?