feat(pyth-lazer-agent) Make the id in jrpc request optional
#2897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bplatak
changed the title
id in jrpc request optional
merolish
approved these changes
Jul 24, 2025
darunrs
approved these changes
Jul 24, 2025
Riateche
approved these changes
Jul 28, 2025
For the time being we're using our own types but we will refactor it later. See #2836 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow omitting the
idin the json request and add a new error type. Also fix an issuer with deserialisingJrpcResponse<...>.Rationale
We are giving the clients an option to disable receiving successful send acknowledgments by omitting the
idparameter from the request body (making it a notification rather than a request). PF-334How has this been tested?