Skip to content

test_monitoring contains hardcoded line numbers #115836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
swtaarrs opened this issue Feb 23, 2024 · 1 comment
Closed

test_monitoring contains hardcoded line numbers #115836

swtaarrs opened this issue Feb 23, 2024 · 1 comment
Assignees
@swtaarrs
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@swtaarrs
Copy link
Member

swtaarrs commented Feb 23, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

test_lines_single, test_lines_loop, and test_lines_two in test_monitoring.LinesMonitoringTest all contain some hardcoded line numbers in their expected values. They should consistently use offsets from co_firstlineno on the relevant code objects instead.

I ran into this while adding a test for gh-115832, and already have a fix ready to put up as a PR.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs
@swtaarrs swtaarrs added the type-bug An unexpected behavior, bug, or error label Feb 23, 2024
@AlexWaygood AlexWaygood added the tests Tests in the Lib/test dir label Feb 23, 2024
swtaarrs added a commit to swtaarrs/cpython that referenced this issue Feb 23, 2024
@swtaarrs
pythongh-115836: Don't use hardcoded line numbers in test_monitoring
f5aeb67 
Some of the expected line numbers are already offsets from `co_firstlineno`,
but a few more needed to be converted.

- Issue: pythongh-115836
@swtaarrs swtaarrs mentioned this issue Feb 23, 2024
Merged
carljm pushed a commit that referenced this issue Feb 23, 2024
@swtaarrs
gh-115836: Don't use hardcoded line numbers in test_monitoring (#115837)
a494a3d
@itamaro
Copy link
Contributor

itamaro commented Feb 23, 2024

Fix merged, closing the issue (please reopen if there's more left to do here).

@itamaro itamaro closed this as completed Feb 23, 2024
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this issue Mar 4, 2024
@swtaarrs @woodruffw
pythongh-115836: Don't use hardcoded line numbers in test_monitoring (p…
ee9828e 
…ython#115837)
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@swtaarrs @diegorusso
pythongh-115836: Don't use hardcoded line numbers in test_monitoring (p…
f704295 
…ython#115837)
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this issue Jan 22, 2025
@swtaarrs @LukasWoodtli
pythongh-115836: Don't use hardcoded line numbers in test_monitoring (p…
6a5940b 
…ython#115837)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swtaarrs swtaarrs

Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@swtaarrs @itamaro @AlexWaygood