gh-115836: Don't use hardcoded line numbers in test_monitoring #115837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the expected line numbers are already offsets from `co_firstlineno`, but a few more needed to be converted. - Issue: pythongh-115836
carljm
reviewed
Feb 23, 2024
| @@ -0,0 +1 @@ | |||
| Stop using hardcoded line numbers in ``test_monitoring``. | |||
There was a problem hiding this comment.
We don't really need this for a non-user-facing change. This PR is a reasonable case for the skip-news label (which I know you can't currently apply yourself...)
There was a problem hiding this comment.
Thanks, I was wondering about when that's appropriate. I almost asked someone to add the label but it was quicker to add a news entry with blurb-it :). I'll keep this in mind for the future.
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
LukasWoodtli
pushed a commit
to LukasWoodtli/cpython
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the expected line numbers are already offsets from
co_firstlineno, but a few more needed to be converted.