-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Support pythonπ
in Python 3.14 venv's
#119535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I guess I'm too boring, but I'm -1 on this. This would a nice-ish easter egg, but we'd have to revert for 3.15 and that opens up backward compatibility issues. |
|
I have seen cute things like this break systems . I believe racket-lang had some birthday code trigger but then it broke the system on that day. Who knows what this would break and it seems too hard to test. |
Still, someone might start using pythonπ in a shell script with 3.14 and then gets a broken script once upgrading to 3.15 because pythonπ doesn't exist there. That's not a very likely scenario, but still. And yes, this would have to be reverted in 3.15 because otherwise we'd end up with dead code in the stdlib. |
Unlike most easter eggs, this will be directly presented to users because it will appear in tab completion, so you will get questions about it. Users without Unicode fonts in their terminal will be extra confused. I don't think it is worth the support burden. |
I agree with @ronaldoussoren. But, I still advocate for using |
The same argument would apply to using "python3.14" in a shell script Not wanting easter eggs is a valid personal difference, they are sometimes contentious (even if the CPython project has a history of a few). I think as far as they go, this one is predictable and harmless. I do concede that in 3.15 it would create two dead lines of code (since it's version gated, fully dead, no deadline to revert) — to me that's a reasonable cost for a little bit of joy. I've heard some FUD about the use of a Greek character. It's 2024, I'm genuinely curious, does anyone have an example of a platform/filesystem we support that this would cause a real issue on? (π is not that special, it's fully normalised Unicode. I couldn't find problems when looking into it, also note the change is restricted to |
Minor releases 3.14.1, 3.14.15, 3.14.159, ... (or rather 3.14.2, 3.14.16, 3.14.159...)? But |
Proof that easter eggs do create maintenance costs and bugs: #124960 |
How about displaying 3.14.2, 3.14.3, ... as 3.14.15, 3.14.159... in the REPL? Because I'm afraid
The chance at bugs should be lower since it's just for one release (and not as complicated as |
Well, with something like ~20 minor releases this will be >>> "3.14."+f"{gmpy2.const_pi():.22f}"[4:]
'3.14.15926535897932384626' On another hand, current 1st line of the banner doesn't fit common default of 80 characters width anyway... ;)
Yeah, and rather impossible. 159 will be the last minor version, that increases monotonically and don't mess with major or minor version. |
Whilst this is technically possible, our development process uses a backport workflow apart from exceptional cases. More importantly, 3.14 will be branched at beta 1, where no new features are allowed. So it would need to be merged now.
I concur. This is a bit of fun, easily noticable, and a tongue-in-cheek reference to the "pi" release of Python. Remember that the language itself is named after a fairly irreverent programme! A |
Oh damn, turns out this was an easter egg. A while back, I was seriously telling the author that maybe ASCII characters should be used. Looks like I’m just old-fashioned. |
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Merged. Now, everyone: shhh! |
I'll be that annoying guy now: |
This reverts commit 3fc673e.
Feature or enhancement
Proposal:
Linked PRs
The text was updated successfully, but these errors were encountered: