Skip to content

gh-119535: Support 𝜋thon in Python 3.14 venvs #125035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024
Merged

gh-119535: Support 𝜋thon in Python 3.14 venvs #125035

merged 1 commit into from
Oct 15, 2024

Conversation

foreignmeloman
Copy link
Contributor

@foreignmeloman foreignmeloman commented Oct 7, 2024

@foreignmeloman foreignmeloman requested a review from vsajip as a code owner October 7, 2024 09:15
@ghost
Copy link

ghost commented Oct 7, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Oct 7, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@skirpichev
Copy link
Member

I would guess, it's already too late;) And sounds wrongly: "Pi", not "Py".

@hugovk
Copy link
Member

hugovk commented Oct 7, 2024

It's not too late.

In English, the py of python and pi are pronounced the same: /paɪ/ in IPA.

@thatbirdguythatuknownot
Copy link
Contributor

Also doesn't reveal the easter egg to terminal autocomplete (as far as i know autocomplete goes)

@foreignmeloman
Copy link
Contributor Author

Also doesn't reveal the easter egg to terminal autocomplete (as far as i know autocomplete goes)

Was it intended to show during the tab completion?

@@ -306,7 +306,7 @@ def setup_python(self, context):

suffixes = ['python', 'python3', f'python3.{sys.version_info[1]}']
if sys.version_info[:2] == (3, 14):
suffixes.append('python𝜋')
suffixes.append('𝜋thon')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we have both of them? 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should decide on one option. An easter egg should be unique, otherwise it'll loose its punch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I suggest creating the concept of an easter omlet)

Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hugo asked me if I have an opinion on this. I don't have a strong opinion, but for whatever it's worth I chose python𝜋 in the original PR because:

  • I think it's much easier to use, since your tab completion is narrowed to like four options. Especially so after the switch from U+03c0 to U+1d70b (I can type U+03c0 on my keyboard pretty easily but not U+1d70b)
  • Subjective, but to me some of the joke comes from the substitution of 3.14 in the "python3.14" file that venv creates. It's clearer that it's specific to this specific version of Python

@hugovk
Copy link
Member

hugovk commented Oct 15, 2024

Okay, let's go for this one :)

Remember, everyone: shhh!

@hugovk hugovk changed the title gh-119535: 𝜋thon looks and sounds way cooler gh-119535: Support 𝜋thon in Python 3.14 venvs Oct 15, 2024
@hugovk hugovk merged commit fcef3fc into python:main Oct 15, 2024
34 checks passed
hugovk added a commit to hugovk/cpython that referenced this pull request May 15, 2025
hauntsaninja pushed a commit that referenced this pull request May 15, 2025
* Revert "gh-119535: Support 𝜋thon in Python 3.14 venvs (#125035)"

This reverts commit fcef3fc.

* Revert "gh-119535: python𝜋 (#119536)"

This reverts commit 3fc673e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants