-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-119535: Support 𝜋thon in Python 3.14 venvs #125035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
I would guess, it's already too late;) And sounds wrongly: "Pi", not "Py". |
Also doesn't reveal the easter egg to terminal autocomplete (as far as i know autocomplete goes) |
Was it intended to show during the tab completion? |
@@ -306,7 +306,7 @@ def setup_python(self, context): | |||
|
|||
suffixes = ['python', 'python3', f'python3.{sys.version_info[1]}'] | |||
if sys.version_info[:2] == (3, 14): | |||
suffixes.append('python𝜋') | |||
suffixes.append('𝜋thon') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't we have both of them? 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should decide on one option. An easter egg should be unique, otherwise it'll loose its punch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I suggest creating the concept of an easter omlet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hugo asked me if I have an opinion on this. I don't have a strong opinion, but for whatever it's worth I chose python𝜋
in the original PR because:
- I think it's much easier to use, since your tab completion is narrowed to like four options. Especially so after the switch from U+03c0 to U+1d70b (I can type U+03c0 on my keyboard pretty easily but not U+1d70b)
- Subjective, but to me some of the joke comes from the substitution of 3.14 in the "python3.14" file that venv creates. It's clearer that it's specific to this specific version of Python
Okay, let's go for this one :) Remember, everyone: shhh! |
𝜋thon
looks and sounds way cooler
pythonπ
in Python 3.14 venv's #119535