-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-102110: Add all tools description missed #102625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Add some clarifications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tools/README
Outdated
.build Automatically generated directory by the build system | ||
contain build artifacts and intermediate files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this info about the Tools/.build
directory come from? I don't seem to have one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a self deduction, in my understanding this folder contain files necessary to run the python interpreter and are generated by the build process of the Python interpreter itself.
Don't know if it's correct, but sorry if not, if you can gave me some explanation it's will be helpful !
Thank you for your replying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What operating system are you using, and what build instructions did you follow?
I'm on macOS and there's no Tools/.build
after following https://devguide.python.org/getting-started/setup-building/#macos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using Ubuntu distribution and i follow instructions from https://devguide.python.org/getting-started/setup-building/#macos and with analyzing the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, well I think it's better to leave .build
out, it's not tools in Git and isn't generated for all platforms. And I see you've already removed it, so thank you :)
i added all the suggested changes, waiting for your answer on my questions for the others. Thank you again for your assistant and reviewing. |
Thanks for the updates! I left a few more suggestions. |
changes somes descriptions.
I added it and commit it, hope it's will be good. Still available for another changes or something else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit more whitespace to remove.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Thank you for your contribution! |
Status check is done, and it's a success ✅. |
You're welcome, thank you for your assistance and reviewing. |
Added missing descriptions of some tools. Automerge-Triggered-By: GH:hugovk
Added missing descriptions of some tools.
Automerge-Triggered-By: GH:hugovk