Skip to content

gh-102110: Add all tools description missed #102625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 30, 2023

Conversation

Missoupro
Copy link
Contributor

@Missoupro Missoupro commented Mar 12, 2023

Added missing descriptions of some tools.

Automerge-Triggered-By: GH:hugovk

@bedevere-bot

This comment was marked as resolved.

@ghost
Copy link

ghost commented Mar 12, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@AlexWaygood AlexWaygood changed the title Add all tools description missed gh-102110: Add all tools description missed Mar 12, 2023
@Missoupro Missoupro requested a review from sobolevn March 16, 2023 15:10
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tools/README Outdated
Comment on lines 4 to 5
.build Automatically generated directory by the build system
contain build artifacts and intermediate files.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this info about the Tools/.build directory come from? I don't seem to have one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a self deduction, in my understanding this folder contain files necessary to run the python interpreter and are generated by the build process of the Python interpreter itself.

Don't know if it's correct, but sorry if not, if you can gave me some explanation it's will be helpful !

Thank you for your replying.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What operating system are you using, and what build instructions did you follow?

I'm on macOS and there's no Tools/.build after following https://devguide.python.org/getting-started/setup-building/#macos

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using Ubuntu distribution and i follow instructions from https://devguide.python.org/getting-started/setup-building/#macos and with analyzing the file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, well I think it's better to leave .build out, it's not tools in Git and isn't generated for all platforms. And I see you've already removed it, so thank you :)

@Missoupro
Copy link
Contributor Author

i added all the suggested changes, waiting for your answer on my questions for the others.

Thank you again for your assistant and reviewing.

@Missoupro Missoupro requested a review from hugovk March 21, 2023 16:17
@hugovk
Copy link
Member

hugovk commented Mar 26, 2023

Thanks for the updates! I left a few more suggestions.

changes somes descriptions.
@Missoupro
Copy link
Contributor Author

Thanks for the updates! I left a few more suggestions.
You're welcome ! thank you for your suggestons.

I added it and commit it, hope it's will be good.

Still available for another changes or something else.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit more whitespace to remove.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@hugovk
Copy link
Member

hugovk commented Mar 30, 2023

Thank you for your contribution!

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit 01a49d1 into python:main Mar 30, 2023
@Missoupro
Copy link
Contributor Author

Thank you for your contribution!

You're welcome, thank you for your assistance and reviewing.

warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
Added missing descriptions of some tools.

Automerge-Triggered-By: GH:hugovk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants