Skip to content

gh-102110: Updated cpython/Tools/README #103111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

gh-102110: Updated cpython/Tools/README #103111

wants to merge 6 commits into from

Conversation

TylerBurgee
Copy link

@TylerBurgee TylerBurgee commented Mar 29, 2023

gh-102110: Updated current cpython/Tools subdirectories and descriptions in README.

Added all cpython/Tools subdirectories to the README and included descriptions for the following subdirectories:

  • c-analyzer
  • cases_generator
  • importbench
  • nuget
  • wasm

Added all cpython/Tools modules to the README and included descriptions for the following modules:
- c-analyzer
- cases_generator
- importbench
- nuget
- wasm

*Question: Should we remove the parser module from README? I do not see it listed in cpython/Tools anymore.
@ghost
Copy link

ghost commented Mar 29, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@TylerBurgee TylerBurgee changed the title Update cpython/Tools/README gh-102110: Updated cpython/Tools/README Mar 29, 2023
@arhadthedev
Copy link
Member

According to ...s in the changes, the PR is in progress. Probably you should convert it into a draft to not confuse reviewers.

@arhadthedev
Copy link
Member

Or just delete these lines since Several modules still require descriptions in the news entry covers it.

@TylerBurgee
Copy link
Author

According to ...s in the changes, the PR is in progress. Probably you should convert it into a draft to not confuse reviewers.
Or just delete these lines since Several modules still require descriptions in the news entry covers it.

Thank you for your feedback! I will convert this PR to a draft and make the changes you suggested.

@TylerBurgee TylerBurgee marked this pull request as draft March 30, 2023 12:26
Provided descriptions for the remaining modules. Removed parser from README, as this module no longer exists in cpython/Tools.
@TylerBurgee TylerBurgee marked this pull request as ready for review March 30, 2023 15:08
@TylerBurgee
Copy link
Author

TylerBurgee commented Mar 30, 2023

gh-102110: Updated cpython/Tools/README to include descriptions for all current modules in cpython/Tools.

Added descriptions for the folllowing cpython/Tools modules to cpython/Tools/README:


  • build
  • clinic
  • patchcheck
  • ssl
  • tz
  • c-analyzer
  • cases_generator
  • importbench
  • nuget
  • wasm

Removed parser from README, as this module no longer exists in cpython/Tools.

@arhadthedev
Copy link
Member

@TylerBurgee Please ping me if nobody reviews this PR until next Friday so I could ping all active developers affected for review:

  • ericsnowcurrently (build and c-analyzer)
  • gvanrossum (cases-generator)
  • erlend-aasland (clinic)
  • zooba (nuget)
  • zware (patchcheck)
  • vstinner (wasm)

@TylerBurgee
Copy link
Author

@arhadthedev Okay, will do!

@hugovk
Copy link
Member

hugovk commented Mar 30, 2023

Thank you for the PR, however there were already two open PRs for this listed on the issue:

Sorry for any mixup, I suggest next time picking something that doesn't already have open PRs.

@hugovk hugovk closed this Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants