gh-105331: Fix asyncio.sleep() bug #105501
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
weijay0804
commented
Jun 8, 2023
•
weijay0804
commented
- Issue: asyncio.sleep(float('nan')) does not raise ValueError #105331
- Issue: asyncio.sleep(float('nan')) does not raise ValueError #105331
weijay0804
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
All commit authors signed the Contributor License Agreement. |
Eclips4
reviewed
Jun 8, 2023
| @@ -639,10 +639,34 @@ def __sleep0(): | |||
| """ | |||
| yield | |||
|
|
|||
| def __check_delay(delay): | |||
There was a problem hiding this comment.
Nitpick: Does it really need double underscore? If you want to mark something as "private API" use one leading underscore
There was a problem hiding this comment.
Get it!
Thank you
Eclips4
reviewed
Jun 8, 2023
|
|
||
| SEC_TO_NS = 1000 * 1000 * 1000 | ||
|
|
||
| if not (isinstance(delay, int) or isinstance(delay, float)): |
There was a problem hiding this comment.
Suggested change
| if not (isinstance(delay, int) or isinstance(delay, float)): | |
| if not isinstance(delay, (int, float)): |
There was a problem hiding this comment.
Wow! This is much clearer now.
Eclips4
reviewed
Jun 8, 2023
| SEC_TO_NS = 1000 * 1000 * 1000 | ||
|
|
||
| if not (isinstance(delay, int) or isinstance(delay, float)): | ||
| raise TypeError(f"'{type(delay)} object cannot be interpreted as an integer'") |
There was a problem hiding this comment.
Suggested change
| raise TypeError(f"'{type(delay)} object cannot be interpreted as an integer'") | |
| raise TypeError(f"{type(delay)} object cannot be interpreted as an integer") |
There's no need for single quotes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.