-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-105331: Fix asyncio.sleep() bug #105501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -639,10 +639,34 @@ def __sleep0(): | |||||
""" | ||||||
yield | ||||||
|
||||||
def __check_delay(delay): | ||||||
"""Check if the value of 'delay' is valid.""" | ||||||
|
||||||
import sys | ||||||
import math | ||||||
|
||||||
SEC_TO_NS = 1000 * 1000 * 1000 | ||||||
|
||||||
if not (isinstance(delay, int) or isinstance(delay, float)): | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wow! This is much clearer now. |
||||||
raise TypeError(f"'{type(delay)} object cannot be interpreted as an integer'") | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There's no need for single quotes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok |
||||||
|
||||||
# According to Modules/timemodule.c | ||||||
if (delay > sys.maxsize / SEC_TO_NS): | ||||||
raise OverflowError("timestamp too large to convert to C _PyTime_t") | ||||||
|
||||||
if (delay < 0): | ||||||
raise ValueError("sleep length must be non-negative") | ||||||
|
||||||
if (math.isnan(delay)): | ||||||
raise ValueError("Invalid value NaN (not a number)") | ||||||
|
||||||
|
||||||
async def sleep(delay, result=None): | ||||||
"""Coroutine that completes after a given time (in seconds).""" | ||||||
if delay <= 0: | ||||||
|
||||||
__check_delay(delay) | ||||||
|
||||||
if delay == 0: | ||||||
await __sleep0() | ||||||
return result | ||||||
|
||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Fix asyncio.sleep(float('nan')) does not raise ValueError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: Does it really need double underscore? If you want to mark something as "private API" use one leading underscore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get it!
Thank you