gh-108732: include comprehension locals in frame.f_locals #109026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
chgnrdv
reviewed
Sep 6, 2023
Co-authored-by: Radislav Chugunov <[email protected]>
This failure is unrelated to this PR. Apparently, a test_asyncio test is unable on FreeBSD: I created issue #109051 to track it. |
JelleZijlstra
approved these changes
Sep 7, 2023
Misc/NEWS.d/next/Core and Builtins/2023-09-06-13-28-42.gh-issue-108732.I6DkEQ.rst
Show resolved
Hide resolved
Misc/NEWS.d/next/Core and Builtins/2023-09-06-13-28-42.gh-issue-108732.I6DkEQ.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra
approved these changes
Sep 7, 2023
|
Thanks @carljm for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 7, 2023
…onGH-109026) (cherry picked from commit f2584ea) Co-authored-by: Carl Meyer <[email protected]> Co-authored-by: Radislav Chugunov <[email protected]> Co-authored-by: Jelle Zijlstra <[email protected]>
|
GH-109097 is a backport of this pull request to the 3.12 branch. |
Yhg1s
pushed a commit
that referenced
this pull request
Sep 12, 2023
…109026) (#109097) gh-108732: include comprehension locals in frame.f_locals (GH-109026) (cherry picked from commit f2584ea) Co-authored-by: Carl Meyer <[email protected]> Co-authored-by: Radislav Chugunov <[email protected]> Co-authored-by: Jelle Zijlstra <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the same fix that was made for
locals()in #105715 tosys._getframe().f_localsas well. This is mostly relevant because pdb uses the latter, so this fix makes these comprehension locals (in module- or class-scope comprehensions) visible to pdb.I also made one small fix in passing to
PyFrame_FastToLocalsWithError; the assertion and the null check were in the wrong order, since the assertion would segfault before ever hitting the null check, iffwere null. (Of course if assertions are turned off, the order doesn't matter either way.)frame.f_localsfor list/dict/set comprehension in module/class scope doesn't contain iteration variables #108732