Skip to content

[3.12] gh-108732: include comprehension locals in frame.f_locals (GH-109026) #109097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 7, 2023

(cherry picked from commit f2584ea)

Co-authored-by: Carl Meyer [email protected]
Co-authored-by: Radislav Chugunov [email protected]
Co-authored-by: Jelle Zijlstra [email protected]

…onGH-109026)

(cherry picked from commit f2584ea)

Co-authored-by: Carl Meyer <[email protected]>
Co-authored-by: Radislav Chugunov <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
@carljm
Copy link
Member

carljm commented Sep 7, 2023

@Yhg1s I think this fix is safe (doesn't touch anything other than frame.f_locals getter), but also the issue is not super-critical, so up to you whether you want to merge this for 3.12.0 or leave it for 3.12.1.

@carljm
Copy link
Member

carljm commented Sep 8, 2023

If we are going to do an rc3, then I think this should go into it. It does fix a 3.12 regression, and if the fix does have any unexpected repercussions, it's better to find that out in rc3 than in .1.

@Yhg1s Yhg1s merged commit d533ab1 into python:3.12 Sep 12, 2023
@miss-islington miss-islington deleted the backport-f2584ea-3.12 branch September 12, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frame.f_locals for list/dict/set comprehension in module/class scope doesn't contain iteration variables
4 participants