Skip to content

gh-101137: Add text/x-rst to mimetypes #118593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2024
Merged

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented May 5, 2024

@sobolevn sobolevn requested a review from jaraco May 5, 2024 13:08
@sobolevn sobolevn requested a review from a team as a code owner May 5, 2024 13:08
@bedevere-app bedevere-app bot mentioned this pull request May 5, 2024
@sobolevn
Copy link
Member Author

sobolevn commented May 5, 2024

Ok, I found #17995
Removing the md part from this PR.

@sobolevn sobolevn changed the title gh-101137: Add text/x-rst and text/markdown to mimetypes gh-101137: Add text/x-rst to mimetypes May 5, 2024
@jaraco
Copy link
Member

jaraco commented May 5, 2024

Thanks for getting this done before I committed and proposed the same change :)

@jaraco jaraco enabled auto-merge (squash) May 5, 2024 13:29
@jaraco jaraco removed the request for review from a team May 5, 2024 13:29
@jaraco jaraco merged commit 1511bc9 into python:main May 5, 2024
35 checks passed
@sobolevn
Copy link
Member Author

sobolevn commented May 5, 2024

Do we want a backport?

@jaraco
Copy link
Member

jaraco commented May 5, 2024

Do we want a backport?

I'm unsure. For #17995, I contend that it definitely deserves a backport, since text/markdown is unequivocally in the standards list (so it's a bug that it's missing from the behavior). text/x-rst, however, is less formally recognized, so is less obviously a bug, so I'm slightly inclined not to back port it and treat it like a feature. On the other hand, text/x-rst is also standardized in the Python packaging ecosystem, so also seems like an obvious shortcoming. I'll flag this one for backport too, but without prejudice (and give the release manager some time to review after text/markdown).

@jaraco jaraco added the needs backport to 3.12 only security fixes label May 5, 2024
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @sobolevn and @jaraco, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1511bc95c4bc95bd35599dc9c88111c9aac44c0d 3.12

@jaraco jaraco assigned sobolevn and unassigned jaraco May 5, 2024
@jaraco
Copy link
Member

jaraco commented May 5, 2024

@sobolevn Would you reconcile the backport? Thanks.

sobolevn added a commit to sobolevn/cpython that referenced this pull request May 5, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 5, 2024

GH-118599 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label May 5, 2024
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
ambv pushed a commit that referenced this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants