Skip to content

bpo-39324: Add markdown mimetype mapping #17995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2024
Merged

Conversation

rdbatch
Copy link
Contributor

@rdbatch rdbatch commented Jan 13, 2020

Adding markdown mapping (.md <-> text/markdown) to mimetypes as registered here https://www.iana.org/assignments/media-types/text/markdown.

https://bugs.python.org/issue39324

@rdbatch rdbatch requested a review from a team as a code owner January 13, 2020 20:04
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@rdbatch02

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @rdbatch02 thanks for the PR. IMHO this should be discuss, I recommend you write to python-ideas mailing list, but the opened the issue it's ok.

This will need a NEWS. And don't forget sign the CLA

@rdbatch
Copy link
Contributor Author

rdbatch commented Jan 14, 2020

Hi, @rdbatch02 thanks for the PR. IMHO this should be discuss, I recommend you write to python-ideas mailing list, but the opened the issue it's ok.

This will need a NEWS. And don't forget sign the CLA

Hi @eamanu, I've added a NEWS and it looks like the CLA went through. Should I plan to submit this to the mailing list as well in addition to the issue that I opened? Or can discussion be solicited on the open issue?

@tirkarthi
Copy link
Member

The RFC also includes .markdown as an extension though I have seen .md to be more common

Relevant part : "File extension(s): .md, .markdown"

@rdbatch
Copy link
Contributor Author

rdbatch commented Jan 21, 2020

Thanks for the heads up on that @tirkarthi, I haven't seen the .markdown extension myself but it's worth adding since it's in the RFC. Updated this PR.

@legendofa
Copy link

Hi, is there something in the way of merging this? Which of the checks are not completed yet?

@jaraco jaraco enabled auto-merge (squash) May 5, 2024 12:47
@jaraco
Copy link
Member

jaraco commented May 5, 2024

@Yhg1s Would you agree this is a bugfix? It seems a shame to leave this missing important content type to be missing for years to come.

Edit: I'm going to assume it's okay to treat as a bugfix, but we can follow-up in the backport(s).

@jaraco jaraco added the needs backport to 3.12 only security fixes label May 5, 2024
@jaraco jaraco requested review from jaraco and removed request for a team May 5, 2024 12:58
@jaraco jaraco merged commit b6f0ab5 into python:main May 5, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks @rdbatch02 for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 5, 2024
(cherry picked from commit b6f0ab5)

Co-authored-by: Ryan Batchelder <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 5, 2024

GH-118594 is a backport of this pull request to the 3.12 branch.

@vstinner
Copy link
Member

vstinner commented Aug 6, 2024

What's the status of the 3.12 backport? #118594

jaraco pushed a commit that referenced this pull request Aug 6, 2024
gh-83505: Add markdown mimetype mapping (GH-17995)
(cherry picked from commit b6f0ab5)

Co-authored-by: Ryan Batchelder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants