Skip to content

[3.6] bpo-29532: Altering a kwarg dictionary passed to functools.partial() no longer affects a partial object after creation. #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[3.6] bpo-29532: Altering a kwarg dictionary passed to functools.partial() no longer affects a partial object after creation. #198

wants to merge 4 commits into from

Conversation

serhiy-storchaka
Copy link
Member

No description provided.

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error cherry-pick for 3.6 labels Feb 20, 2017
@methane methane changed the base branch from master to 3.6 February 20, 2017 12:31
@methane methane changed the base branch from 3.6 to master February 20, 2017 12:32
@mdickinson
Copy link
Member

mdickinson commented Feb 20, 2017 •
edited
Loading

There's something odd going on here: the diff shown by GitHub looks unrelated to bpo-29532, and instead looks related to bpo-29602.

@methane
Copy link
Member

methane commented Feb 21, 2017

@serhiy-storchaka This pull request seems broken.
Would you close this PR and create new one? Right step to cherry pick may be like this:

# Assuming upstream is python/cpython and origin is fork
git fetch --prune upstream
git checkout -b bpo29532-py36 upstream/3.6
git cherry-pick 29532
git push origin bpo29532

@serhiy-storchaka
Copy link
Member Author

Sorry. Thank you @methane, I'll try to use your commands.

@berkerpeksag
Copy link
Member

Using git cherry-pick -x would even be better.

akruis pushed a commit to akruis/cpython that referenced this pull request Jan 3, 2019
Stackless issue python#198: Improve the soft-switchable extension fun…
9c2dabb 
…ctions

Better handling of exceptions / NULL result values.
Move the macros to manipulate the try-stackless floag to the API.
Now it is possible to convert existing extension functions to stackless,
without using internal API.
Coming soon: test cases and documentation
akruis pushed a commit to akruis/cpython that referenced this pull request Jan 3, 2019
Stackless issue python#197: stackless call "asyncio._CTask"
06cb695 
Enable stackless calls of coroutines wrapped in "asyncio._CTask", if
soft-switching is enabled.
Needs test cases.
Depends on pull request python#198.
akruis pushed a commit to akruis/cpython that referenced this pull request Jan 5, 2019
Stackless issue python#198: Improve the soft-switchable extension fun…
e3001b5 
…ctions

Clean up the API header, add tests and documentation.
akruis pushed a commit to akruis/cpython that referenced this pull request Jan 6, 2019
Stackless issue python#198: Improve the soft-switchable extension fun…
35f7fd9 
…ctions

Add a reference to _asyncio._task_step_impl_stackless to the
documentation.
akruis pushed a commit to akruis/cpython that referenced this pull request Jan 6, 2019
Not to be pushed: diffs to PR python#198 and python#199
e093c8d
akruis pushed a commit to akruis/cpython that referenced this pull request Jan 12, 2019
Stackless issue python#198: Improve the soft-switchable extension fun…
722a1e4 
…ctions

Fix a potential uninitialized variable usage and add some comments.
akruis pushed a commit to akruis/cpython that referenced this pull request Jan 12, 2019
Stackless issue python#198: Improve the soft-switchable extension fun…
f24223f 
…ctions

Better handling of exceptions / NULL result values.
Move the macros to manipulate the try-stackless floag to the API.
Now it is possible to convert existing extension functions to stackless,
without using internal API.
akruis pushed a commit to akruis/cpython that referenced this pull request Jan 12, 2019
Stackless issue python#198: Improve the soft-switchable extension fun…
1dc7128 
…ctions

Fix a reference leak in the demo/test code.
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@pyup-bot @Mariatta
Update pytest from 4.0.2 to 4.1.0 (#198)
7f81a57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @mdickinson @methane @berkerpeksag @the-knights-who-say-ni