bpo-15216: TextIOWrapper support set encoding, errors and newline after creation #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methane
commented
Feb 20, 2017
| { | ||
| PyObject *encoding = Py_None; | ||
| const char *errors = NULL; | ||
| const char *newline = (const char *)&newline; /* Unique non-NULL value */ |
There was a problem hiding this comment.
Can I convert this hack into AC easily?
methane
changed the title
methane
changed the title
|
I gave up on using AC for set_encoding(). |
methane
force-pushed
the
set-encoding-after-creation
branch
from
ec98cda to
e7f16ac
Compare
methane
force-pushed
the
set-encoding-after-creation
branch
from
e7f16ac to
f5a2c5e
Compare
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jan 6, 2019
Remove an unused static function, add test cases and change-log.
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jan 6, 2019
Remove an unused static function, add test cases and change-log.
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jan 6, 2019
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jan 12, 2019
Enable stackless calls of coroutines wrapped in "asyncio._CTask", if soft-switching is enabled.
pablogsal
pushed a commit
to pablogsal/cpython
that referenced
this pull request
Nov 29, 2022
* Handle the case where raw-fstrings with curly braces crash * Ensure we are not ignoring double brackets when skipping backslash * Handle more variations of escapes in a tidier way for french strs * Properly handle }} inside f-string format specifiers * Update Parser/tokenizer.c
jaraco
added a commit
to jaraco/cpython
that referenced
this pull request
Feb 17, 2023
ci: fix diffcov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[bpo-15216]