bpo-39349: Add cancel_futures to Executor.shutdown base class

[hauntsaninja]

https://bugs.python.org/issue39349

[hauntsaninja]

cc @aeros

Seems like we can skip news, since the parameter is new in 3.9. We should also backport to 3.9.

[aeros]

Thanks for the PR @hauntsaninja! I've edited the title slightly to reflect that it's adding cancel_futures to the base class so that the title is more distinct original PR that added the feature. Other than that, it looks good to me. I'll restart the CI by reopening and closing since the failures look to be entirely unrelated (I opened a separate issue for the test_asyncio failure in the Windows CI).

[hauntsaninja]

Thanks! It looks like the only CI failures currently are the doctest ones, which there's a python-dev thread about: https://mail.python.org/archives/list/[email protected]/thread/KMXK6BQWQZRR2TGVRLECMR7CUVIVTUMQ/

[aeros]

Thanks! It looks like the only CI failures currently are the doctest ones, which there's a python-dev thread about:

@hauntsaninja No problem. I just read that thread recently, and was about to give an update. I believe the travis failure is also due to it, seeing as its specifically the documentation test failing in the build stage. So I would try pushing a non-functional commit (add some whitespace to between words in the docstring, or between the last word and the period of a sentence) to cause travis to use the older version of setuptools for the doctest. We can also just wait on the fix for setuptools, and then close/re-open the PR later; I'll leave it up to you.

(I'm unable to merge until at least all of the required checks are passing.)

[aeros]

Thanks! I'll proceed with merging.

[miss-islington]

Thanks @hauntsaninja for the PR, and @aeros for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

[miss-islington]

Sorry @hauntsaninja and @aeros, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 17dc1b789ecc33b4a254eb3b799085f4b3624ca5 3.9

[aeros]

@hauntsaninja If you'd like to manually work on backporting to 3.9 with cherry_picker, feel free to @ mention me in the PR. If you're unfamiliar with this process, it's described in a section of the devguide.

[bedevere-bot]

GH-22048 is a backport of this pull request to the 3.9 branch.

[hauntsaninja]

Sure, opened #22048