Skip to content

bpo-39349: Add cancel_futures to Executor.shutdown base class #22023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2020
Merged

bpo-39349: Add cancel_futures to Executor.shutdown base class #22023

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe2dab5
bpo-39349: Add cancel_futures to Executor.shutdown
Aug 31, 2020
94d8ce0
empty commit
Sep 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Lib/concurrent/futures/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ def result_iterator():
future.cancel()
return result_iterator()

def shutdown(self, wait=True):
def shutdown(self, wait=True, *, cancel_futures=False):
"""Clean-up the resources associated with the Executor.

It is safe to call this method several times. Otherwise, no other
Expand All @@ -615,6 +615,9 @@ def shutdown(self, wait=True):
wait: If True then shutdown will not return until all running
futures have finished executing and the resources used by the
executor have been reclaimed.
cancel_futures: If True then shutdown will cancel all pending
futures. Futures that are completed or running will not be
cancelled.
"""
pass

Expand Down