Skip to content

bpo-43988: Use check disallow instantiation helper #26392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 27, 2021
Merged

bpo-43988: Use check disallow instantiation helper #26392

merged 6 commits into from
May 27, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 26, 2021 •
edited by bedevere-bot
Loading

  • Use test.support.check_disallow_instantiation
  • Fix exception message regex for builtins

https://bugs.python.org/issue43988

@erlend-aasland erlend-aasland changed the title bpo-43988: Use check disallow instantiation bpo-43988: Use check disallow instantiation helper May 26, 2021
@erlend-aasland erlend-aasland requested a review from vstinner May 26, 2021 22:45
vstinner
vstinner reviewed May 26, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to avoid tp = ... and then use tp, since "tp" name doesn't help: use directly "...". I wrote some examples.

@vstinner vstinner merged commit fbff538 into python:main May 27, 2021
@vstinner
Copy link
Member

Merged, thanks. This helper makes me more confident that the test actually checks that the type is immutable.

@erlend-aasland erlend-aasland deleted the use-check-disallow-inst branch May 27, 2021 06:44
@erlend-aasland
Copy link
Contributor Author

Merged, thanks. This helper makes me more confident that the test actually checks that the type is immutable.

Great, thanks for reviewing and improving the PR!

@erlend-aasland erlend-aasland mentioned this pull request May 27, 2021
Merged
@erlend-aasland erlend-aasland mentioned this pull request Jun 23, 2021
Merged
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jun 23, 2021
bpo-43988: Use check disallow instantiation helper (pythonGH-26392)
086565a
@erlend-aasland erlend-aasland mentioned this pull request Jun 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

@tiran tiran Awaiting requested review from tiran tiran is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @vstinner @the-knights-who-say-ni @bedevere-bot