Skip to content

bpo-43916: Use test.support.check_disallow_instantiation in test_tcl #26412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 27, 2021

@erlend-aasland erlend-aasland requested a review from vstinner May 27, 2021 18:08
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label May 27, 2021
@erlend-aasland erlend-aasland added needs backport to 3.10 only security fixes skip news and removed needs backport to 3.10 only security fixes labels May 27, 2021
@erlend-aasland
Copy link
Contributor Author

From issue 43988:

Serhiy suggested to write an unit test for curses.ncurses_version:
> https://bugs.python.org/issue43916#msg391936

Excerpt from msg391936:

I think it is better to add tests for different modules in corresponding module test files. They are pretty trivial, for example:

    def test_new_tcl_obj(self):
        self.assertRaises(TypeError, _tkinter.Tcl_Obj)

    @requires_curses_func('panel')
    def test_new_curses_panel(self):
        w = curses.newwin(10, 10)
        panel = curses.panel.new_panel(w)
        self.assertRaises(TypeError, type(panel))

test_new_curses_panel was added in GH-25748 and then converted to use the support helper in GH-26392.

I'm not sure if it makes sense to add a test for curses.ncurses_version.

@vstinner vstinner merged commit e90e042 into python:main May 27, 2021
@vstinner
Copy link
Member

Merged, thanks.

@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2021
@bedevere-bot
Copy link

GH-26888 is a backport of this pull request to the 3.10 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants