bpo-46425: Partially revert GH-30682 #30799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirmed by syncing this change into the backports that the backports no longer show a diff w.r.t the previous change. |
sobolevn
approved these changes
Jan 22, 2022
There was a problem hiding this comment.
Thanks! The only difference between yours and #30800 is that I've left a comment on the very end of each file that is not suitable to be executed directly.
Sorry for a small breakage 🙂
TIL how backporting to https://github.com/python/importlib_metadata process looks like.
|
In #30800, we decided to proceed with option (b), so merging this now (once tests pass). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 57316c5 for files pertaining to importlib.metadata and importlib.resources (rationale).
https://bugs.python.org/issue46425