Skip to content

bpo-46425: Partially revert GH-30682 #30799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions Lib/test/test_importlib/test_compatibilty_files.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
wrap_spec,
)

from test.test_importlib.resources import util
from .resources import util


class CompatibilityFilesTests(unittest.TestCase):
Expand Down Expand Up @@ -100,7 +100,3 @@ def files(self):

def test_spec_path_joinpath(self):
self.assertIsInstance(self.files / 'a', CompatibilityFiles.OrphanPath)


if __name__ == '__main__':
unittest.main()
10 changes: 3 additions & 7 deletions Lib/test/test_importlib/test_contents.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import unittest
from importlib import resources

from test.test_importlib import data01
from test.test_importlib.resources import util
from . import data01
from .resources import util


class ContentsTests:
Expand Down Expand Up @@ -38,10 +38,6 @@ class ContentsNamespaceTests(ContentsTests, unittest.TestCase):
}

def setUp(self):
from test.test_importlib import namespacedata01
from . import namespacedata01

self.data = namespacedata01


if __name__ == '__main__':
unittest.main()
6 changes: 3 additions & 3 deletions Lib/test/test_importlib/test_files.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

from importlib import resources
from importlib.abc import Traversable
from test.test_importlib import data01
from test.test_importlib.resources import util
from . import data01
from .resources import util


class FilesTests:
Expand Down Expand Up @@ -37,7 +37,7 @@ class OpenZipTests(FilesTests, util.ZipSetup, unittest.TestCase):

class OpenNamespaceTests(FilesTests, unittest.TestCase):
def setUp(self):
from test.test_importlib import namespacedata01
from . import namespacedata01

self.data = namespacedata01

Expand Down
8 changes: 2 additions & 6 deletions Lib/test/test_importlib/test_main.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
try:
import pyfakefs.fake_filesystem_unittest as ffs
except ImportError:
from test.test_importlib.stubs import fake_filesystem_unittest as ffs
from .stubs import fake_filesystem_unittest as ffs

from test.test_importlib import fixtures
from . import fixtures
from importlib.metadata import (
Distribution,
EntryPoint,
Expand Down Expand Up @@ -315,7 +315,3 @@ def test_packages_distributions_neither_toplevel_nor_files(self):
prefix=self.site_dir,
)
packages_distributions()


if __name__ == '__main__':
unittest.main()
6 changes: 1 addition & 5 deletions Lib/test/test_importlib/test_metadata_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import importlib
import contextlib

from test.test_importlib import fixtures
from . import fixtures
from importlib.metadata import (
Distribution,
PackageNotFoundError,
Expand Down Expand Up @@ -313,7 +313,3 @@ class InvalidateCache(unittest.TestCase):
def test_invalidate_cache(self):
# No externally observable behavior, but ensures test coverage...
importlib.invalidate_caches()


if __name__ == '__main__':
unittest.main()
6 changes: 3 additions & 3 deletions Lib/test/test_importlib/test_open.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import unittest

from importlib import resources
from test.test_importlib import data01
from test.test_importlib.resources import util
from . import data01
from .resources import util


class CommonBinaryTests(util.CommonTests, unittest.TestCase):
Expand Down Expand Up @@ -68,7 +68,7 @@ def setUp(self):

class OpenDiskNamespaceTests(OpenTests, unittest.TestCase):
def setUp(self):
from test.test_importlib import namespacedata01
from . import namespacedata01

self.data = namespacedata01

Expand Down
4 changes: 2 additions & 2 deletions Lib/test/test_importlib/test_path.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
import unittest

from importlib import resources
from test.test_importlib import data01
from test.test_importlib.resources import util
from . import data01
from .resources import util


class CommonTests(util.CommonTests, unittest.TestCase):
Expand Down
6 changes: 3 additions & 3 deletions Lib/test/test_importlib/test_read.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import unittest

from importlib import import_module, resources
from test.test_importlib import data01
from test.test_importlib.resources import util
from . import data01
from .resources import util


class CommonBinaryTests(util.CommonTests, unittest.TestCase):
Expand Down Expand Up @@ -66,7 +66,7 @@ def test_read_submodule_resource_by_name(self):

class ReadNamespaceTests(ReadTests, unittest.TestCase):
def setUp(self):
from test.test_importlib import namespacedata01
from . import namespacedata01

self.data = namespacedata01

Expand Down
5 changes: 3 additions & 2 deletions Lib/test/test_importlib/test_resource.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
import uuid
import pathlib

from test.test_importlib import data01, zipdata01, zipdata02
from test.test_importlib.resources import util
from . import data01
from . import zipdata01, zipdata02
from .resources import util
from importlib import resources, import_module
from test.support import import_helper
from test.support.os_helper import unlink
Expand Down
5 changes: 1 addition & 4 deletions Lib/test/test_importlib/test_zip.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import sys
import unittest

from test.test_importlib import fixtures
from . import fixtures
from importlib.metadata import (
PackageNotFoundError,
distribution,
Expand Down Expand Up @@ -60,6 +60,3 @@ def test_files(self):
def test_normalized_name(self):
dist = distribution('example')
assert dist._normalized_name == 'example'

if __name__ == '__main__':
unittest.main()