Skip to content

stubtest: Honor VERSIONS file for sub-modules #12062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srittau opened this issue Jan 25, 2022 · 3 comments · Fixed by #12083
Closed

stubtest: Honor VERSIONS file for sub-modules #12062

srittau opened this issue Jan 25, 2022 · 3 comments · Fixed by #12083
Assignees
@sobolevn
Labels
bug mypy got something wrong

Comments

@srittau
Copy link
Contributor

srittau commented Jan 25, 2022

Bug Report

Cf. python/typeshed#6789. Currently, stubtest doesn't honor version ranges in stdlib's VERSIONS file. For example, when testing stdlib with Python 3.9, stubtest will complain about asyncio.mixins failed to find stubs, even though asyncio.mixins is marked as asyncio.mixins: 3.10- in VERSIONS.

Your Environment

  • Mypy version used: as of today, typeshed uses mypy 0.931
@srittau srittau added the bug mypy got something wrong label Jan 25, 2022
@srittau
Copy link
Contributor Author

srittau commented Jan 25, 2022

Cc @sobolevn

@srittau srittau mentioned this issue Jan 25, 2022
Merged
@sobolevn sobolevn self-assigned this Jan 25, 2022
@sobolevn
Copy link
Member

Thanks, @srittau!

@sobolevn
Copy link
Member

I am able to reproduce it locally, let's see why it happens.

@sobolevn sobolevn mentioned this issue Jan 25, 2022
Closed
@hauntsaninja hauntsaninja mentioned this issue Jan 27, 2022
Merged
JukkaL pushed a commit that referenced this issue Jan 27, 2022
@hauntsaninja
stubtest: use VERSIONS for submodules (#12083)
b36d8cf 
Closes #12062
Addresses feedback in #12066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
bug mypy got something wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stubtest: use VERSIONS for submodules hauntsaninja/mypy
2 participants
@srittau @sobolevn