Make sure we use VERSIONS file in typeshed, refs #12062
#12066
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
reviewed
Jan 25, 2022
| @@ -1132,7 +1145,13 @@ def get_typeshed_stdlib_modules(custom_typeshed_dir: Optional[str]) -> List[str] | |||
| if path.stem == "__init__": | |||
| path = path.parent | |||
| module = ".".join(path.relative_to(stdlib_dir).parts[:-1] + (path.stem,)) | |||
| if module.split(".")[0] in packages: | |||
| if ( | |||
| module.split(".")[0] in packages | |||
There was a problem hiding this comment.
This check is now a bit suspect to me:
- It only checks the top-level name of the package.
- And it shouldn't be necessary, since the package name doesn't get added to
packagesif the module is not supported, due to the check above.
|
Thanks for finding this! Yeah, I agree with srittau. I opened a different version in #12083, which should also correctly deal with subsubmodules. |
JukkaL
pushed a commit
that referenced
this pull request
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how I can test this, but local testing shows that everything works fine.
Ideas? 🤔
CC @srittau
Closes #12062