Skip to content

Some Python2 tests are skipped in CI #9473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hauntsaninja opened this issue Sep 23, 2020 · 1 comment · Fixed by #9528
Closed

Some Python2 tests are skipped in CI #9473

hauntsaninja opened this issue Sep 23, 2020 · 1 comment · Fixed by #9528
Labels
bug mypy got something wrong

Comments

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Sep 23, 2020 •
edited
Loading

#9196 appears to have broken tests (https://github.com/python/typeshed/runs/1157402752?check_suite_focus=true, testAssignToComplexReal_python2). It looks like this is because it needs a Python 2 with typing installed. If that isn't the case, the test gets skipped.
@hauntsaninja hauntsaninja added the bug mypy got something wrong label Sep 23, 2020
This was referenced Sep 23, 2020
Merged
Closed
vbarbaresi added a commit to vbarbaresi/mypy that referenced this issue Oct 3, 2020
@vbarbaresi
Travis CI: install typing on python2 to restore some skipped tests
9addc8e 
This used to be installed but was removed in python@def2c63990dd#diff-354f30a63fb0907d4ad57269548329e3L15
in `mypy/util.py:try_find_python2_interpreter()` we try to find a valid python2 interpreter with typing installed.
If we don't find it, tests are skipped.
However on python/typeshed, the CI installs typing on python2, and thus doesn't skip the tests
This caused the broken tests issue python#9473
@vbarbaresi vbarbaresi mentioned this issue Oct 3, 2020
Merged
@vbarbaresi
Copy link
Contributor

It seems that these tests are skipped on purpose, because they're too slow:

mypy/mypy/test/testpythoneval.py

Lines 9 to 10 in 3e77959

Note: These test cases are *not* included in the main test suite, as including
this suite would slow down the main suite too much.

hauntsaninja pushed a commit that referenced this issue Oct 6, 2020
@vbarbaresi
Travis CI: install typing on python2 to restore some skipped tests (#…
2122333 
…9528)

This used to be installed but was removed in def2c63990dd#diff-354f30a63fb0907d4ad57269548329e3L15
in `mypy/util.py:try_find_python2_interpreter()` we try to find a valid python2 interpreter with typing installed.
If we don't find it, tests are skipped.
However on python/typeshed, the CI installs typing on python2, and thus doesn't skip the tests
Resolves #9473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug mypy got something wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Travis CI: install typing on python2 to restore some skipped tests vbarbaresi/mypy
2 participants
@vbarbaresi @hauntsaninja