Travis CI: install typing on python2 to restore some skipped tests #9528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9473
Typing used to be installed on python2 but was removed by this change, I don't know why
in
mypy/util.py:try_find_python2_interpreter()
we try to find a valid python2 interpreter with typing installed.If we don't find it, those tests are skipped.
However on typeshed, the CI installs typing on python2 for mypy self test. Thus it doesn't skip the tests.
This caused the regression issue on typeshed
Test Plan
I ran Travis CI on my forked repo.
I based a branch on 3186281 (the one that caused a python2 regression) and was able to reproduce the failing test: https://travis-ci.org/github/vbarbaresi/mypy/jobs/732473410
I noted that this change unskips around 40 tests (all from
testpythoneval.py
)