Invalidate cache when previously missing stubs are added #5465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
approved these changes
Aug 13, 2018
| for dep in st.ancestors + dependencies + st.suppressed: | ||
| # We don't want to recheck imports marked with '# type: ignore' | ||
| # so we ignore any suppressed module not explicitly re-included | ||
| # from the command line. | ||
| ignored = dep in st.suppressed and dep not in entry_points | ||
| if ignored: | ||
| if ignored and dep not in added: |
There was a problem hiding this comment.
I thought there was already logic to pick up added modules? Does it not work for these purposes?
There was a problem hiding this comment.
My understanding is that the problem is that freshness of a file is determined by whether the suppressed deps are present in the graph. But they are never added to the graph in the first place because of this code (unless they are added as entry points). So I only add them (them == previously suppressed files that are now found) to the graph here in load_graph, and the invalidation is done by the code in process_graph.
This was referenced Aug 31, 2018
ilevkivskyi
added a commit
that referenced
this pull request
Sep 3, 2018
The problem with the initial fix in #5465 is that it assumes that all modules that are in `st.suppressed` that now exist in file system are newly added, while in fact they can be not new if one uses `follow_imports = skip`. My initial guess was that this causes a lot of files become stale. But it actually turns out that the staleness is determined correctly (all the tests I added actually pass on master). However, we still may parse a lot of modules unnecessarily. This PR fixes the performance regression by: not treating modules as newly added if they were added to `st.suppressed` because of `follow_imports = skip` There still some overhead remains -- we need to clone options for module to understand why it got into suppressed dependencies. This can be improved by having to separate suppressed lists, but I think this win will be quite minor and it is not worth the complexity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1910
Fixes #5101