Fix performance regression caused by #5465: daemon part #5556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JukkaL I added the tests that you asked (just fine grained versions of previously added normal incremental tests). It looks like there is only one problematic test but it is not affected by any of the recent changes. I will make performance measurements later on Monday. |
JukkaL
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the original PR #5544 that takes care of the daemon performance regression caused by #5465. (I separated it from original PR as requested by @JukkaL.)
I will add tests I promised in #5544 (daemon variants of the tests added in #5465 and #5544).
This change should not affect semantics, only performance by avoiding cloning options for lots of modules in situation with
--follow-imports=skip.