Test that install actually works #918
Conversation
|
Sorry, I can't review pull requests that change things all over the place without any documentation on what is the purpose of this. Try again by splitting this into atomic changes that address one issue at a time with the smallest reasonable delta -- either a refactoring, a bug fix or a functionality change, and document what each change does. I can't figure out why you are changing things in the tests, for example. |
|
Good luck shipping a program that is completely broken then. I'll just tell everybody to use my fork instead. |
|
Also, you're not one to talk at all about documentation of internals. |
|
Please file an issue if something is unclear about the internals. Complaining about it in comments without explaining what is unclear does not improve things. I can't merge pull requests if I don't understand them, no matter how important the fix is. Are you going to document your PR? |
Closes #915 which is critical.
Remaining issues: #917, #732