Skip to content
This repository was archived by the owner on Jul 5, 2023. It is now read-only.

Fix conversions.py2to3 on unicode strings #67

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Fix conversions.py2to3 on unicode strings #67

merged 1 commit into from
Jan 9, 2019

Conversation

msullivan
Copy link
Collaborator

The introduction of string kinds in #49 missed updating the 2to3 visitor
for it. Update the visit_Str case to pass s.kind to Str.

Fixes #66.

The introduction of string kinds in #49 missed updating the 2to3 visitor
for it. Update the `visit_Str` case to pass `s.kind` to `Str`.

Fixes #66.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@msullivan msullivan requested a review from ilevkivskyi January 8, 2019 21:08
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msullivan
Copy link
Collaborator Author

Going to merge this. We should do another release soon.
(Though mypy doesn't actually need this fix)

@msullivan msullivan merged commit 40dcf10 into master Jan 9, 2019
@msullivan msullivan deleted the fix-str branch January 9, 2019 00:42
@ilevkivskyi
Copy link
Member

Thanks for fixing this! Having tests for this would be great, but the problem is that we dan't have any tests for typed_ast (probably this is another reason to merge it to CPython, that already has tons of tests).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants