Skip to content

METADATA.toml versions redux#2 #6095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srittau opened this issue Sep 30, 2021 · 1 comment · Fixed by #6094
Closed

METADATA.toml versions redux#2 #6095

srittau opened this issue Sep 30, 2021 · 1 comment · Fixed by #6094
Labels
project: policy Organization of the typeshed project

Comments

@srittau
Copy link
Collaborator

srittau commented Sep 30, 2021

One practical problem with the current versioning scheme is that we can't correctly version the dataclasses stub. Current upstream version is 0.8. If we use 0.8 as version, the tests try to install dataclasses==0.8.*, which doesn't work. Similar problems would exist with calver or other exotic versioning schemes.

Currently, the tests try to install f"{distribution}=={version}.*. I would suggest that we allow standard Python version range specifiers in the version field and change most existing versions to use e.g. "5.3.*". The tests would then be changed to simply install f"{distribution}=={version}". This would give us more flexibility.
@srittau srittau added the project: policy Organization of the typeshed project label Sep 30, 2021
@srittau
Copy link
Collaborator Author

srittau commented Sep 30, 2021

To clarify: We allow two forms:

  • x.y.* (the standard, any number of components) - will install the latest x.y version in tests and gets uploaded as version x.y.serial.
  • x.y (any number of components) - will install exactly that version in tests and gets uploaded as version x.y.serial.

srittau added a commit to typeshed-internal/stub_uploader that referenced this issue Sep 30, 2021
@srittau
Accept plain versions or versions ending in ".*"
9d4d56d 
Versions are now free to have any number of dots

Extract fetch_pypi_versions() from read_base_version()

See python/typeshed#6095
@srittau srittau mentioned this issue Sep 30, 2021
Merged
srittau added a commit to typeshed-internal/stub_uploader that referenced this issue Oct 7, 2021
@srittau
Accept plain versions or versions ending in ".*" (#29)
ddffcb2 
Versions are now free to have any number of dots

See python/typeshed#6095
srittau added a commit to srittau/typeshed that referenced this issue Oct 7, 2021
@srittau
Allow third-party versions to end in asterisk
af8e2e9 
This is a first step towards python#6095, where x.y and x.y.* are treated as
equivalent. The next step is to update existing versions to use x.y.*
where applicable and then treat x.y differently.
This was referenced Oct 7, 2021
Merged
Merged
srittau added a commit that referenced this issue Oct 10, 2021
@srittau @Akuli
Allow third-party versions to end in asterisk (#6129)
46fc031 
This is a first step towards #6095, where x.y and x.y.* are treated as
equivalent. The next step is to update existing versions to use x.y.*
where applicable and then treat x.y differently.

Co-authored-by: Akuli <[email protected]>
@srittau srittau linked a pull request Oct 12, 2021 that will close this issue
Update remaining versions for third-party stubs #6094
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
project: policy Organization of the typeshed project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update remaining versions for third-party stubs srittau/typeshed
1 participant
@srittau