Update remaining versions for third-party stubs #6094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove the python2 markers of packages that don't list Python 2 as supported in the latest version.
|
Depends on typeshed-internal/stub_uploader#30 |
Akuli
reviewed
Oct 8, 2021
stubs/dataclasses/METADATA.toml
Outdated
| @@ -1 +1 @@ | |||
| version = "0.1" | |||
| version = "0" | |||
There was a problem hiding this comment.
Is this a typo or intentional?
There was a problem hiding this comment.
Intentional, and unfortunately necessary until #6095 is done. This was actually what spawned that issue. Otherwise, the tests try to install dataclasses==0.1.*, which doesn't exist.
There was a problem hiding this comment.
Can we now set this to 0.*?
There was a problem hiding this comment.
I would actually set this to 0.10.8, since 0.9 might contain API changes. I'll send a PR that adds stars to all other versions first.
Akuli
reviewed
Oct 11, 2021
Co-authored-by: Akuli <[email protected]>
|
Let's do #6146 first, then this should tie up all remaining bits and bobs. |
|
@Akuli I hope I have now addressed all issues. A thorough final review would be appreciated! |
The latest version available on PyPI is 0.8, but for some reason that is uninstallable.
Co-authored-by: Akuli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the python2 markers of packages that don't list Python 2 as supported in the latest version.
This depends on #6093, which should be merged into this branch before merging to verify CI.