Skip to content

Re-export values for click library #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2017
Merged

Conversation

ilinum
Copy link
Contributor

@ilinum ilinum commented Aug 3, 2017

That way the re-exported values can be used as

import click
click.<value>

See #1515

That way they can be used as
```
import click
click.<value>
```
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add trailing commas whenever they make sense.

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you.merge it yourself, editing the commit message?

@ilinum
Copy link
Contributor Author

ilinum commented Aug 3, 2017

@gvanrossum I don't have write access to the typeshed repo, so I can't merge it. Also, I'm not sure what you mean by editing the commit message.

@gvanrossum gvanrossum merged commit 7a580ed into python:master Aug 3, 2017
@ilinum ilinum deleted the re-export-click branch August 3, 2017 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants