Re-export code from _ast into ast #1515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 3, 2017
|
The flake8 linter doesn't like * imports. I wonder if we should just disable that rule in the config file. |
|
Hmm, I think we should disable the rule. But if other people think otherwise, I am happy to fix the import. |
|
Let's disable the rule.
…On Aug 3, 2017 10:41 AM, "Svyatoslav Ilinskiy" ***@***.***> wrote:
Hmm, I think we should disable the rule.
But if other people think otherwise, I am happy to fix the import.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1515 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACwrMg9BCIxFcjs-qW0dLks5hT2nov38ks5sUgYvgaJpZM4OsBoI>
.
|
|
Submitted #1519 to allow star imports. |
|
Please re-merge and re-push this to show the tests are now green.
…On Aug 3, 2017 1:22 PM, "Svyatoslav Ilinskiy" ***@***.***> wrote:
Submitted #1519 <#1519> to allow
star imports.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1515 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACwrMibfAiPk0bpXoI61E2pf4vYJWAYQks5sUiwXgaJpZM4OsBoI>
.
|
|
Merged and pushed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After mypy started hiding imported names in stubs unless
from ... import ...is used, we found an error with stubs of ast module.It looks like ast module should re-export everything in
_astand according to PEP 484, it can do that by doingfrom _ast import *, so this is what this PR does.