Make flake8 not complain about star imports #1519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit disables following flake8 errors: * F403: `‘from module import *’ used; unable to detect undefined names` * F405: `name may be undefined, or defined from star imports: module` We don't need to worry about undefined names since running mypy_test.py should detect such undefined names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit disables following flake8 errors:
‘from module import *’ used; unable to detect undefined namesname may be undefined, or defined from star imports: moduleWe don't need to worry about flake8 not reporting undefined names since running mypy_test.py
should detect undefined names anyway.